DISABLE_DEBUG=1 env variable to build.sh#1373
Merged
liamcottle merged 1 commit intomeshcore-dev:devfrom Jan 14, 2026
Merged
Conversation
Member
|
Looks good, have left one comment :) |
liquidraver
force-pushed
the
buildwithoutdebug
branch
4 times, most recently
from
ebc0b31 to
9289dac
Compare
Contributor
Author
|
I took out MESH_PACKET_LOGGING removal because that is needed for logging repeater releases |
liamcottle
requested changes
Jan 13, 2026
Member
|
Turns out I didn't submit the review... Sorry! |
liquidraver
force-pushed
the
buildwithoutdebug
branch
from
9289dac to
a48b185
Compare
Contributor
Author
|
I've added -UCFG_DEBUG -URADIOLIB_DEBUG_BASIC and -URADIOLIB_DEBUG_PROTOCOL too by @recrof 's recommendation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully I got all of them from the platformio ini-s